chore: migrate from less to scss #3961
Conversation
There was a problem hiding this comment.
This is looking great!
- Could you post a diff of the output CSS other than single/double quote changes?
- I believe Sass
!defaultvalues fix this issue. - Maybe you could update stylelint in a future PR? I don't think this is a high priority though.
One omission I noticed:
docs/font.mdmentionssrc/fonts.lessand needs to change. As an alternative to suggesting changing the file, I think we can suggest overriding the variable.
|
Left is Less compilation result, right is Sass.
Also muting comment applied for each style that was generated in loop
|
docs/font.md
Outdated
| @@ -2,7 +2,7 @@ | |||
| id: font | |||
| title: Font | |||
| --- | |||
| By changing the variables in the `src/fonts.less` file, | |||
| By changing the variables in the `src/fonts.scss` file, | |||
There was a problem hiding this comment.
This path is incorrect (you moved to src/styles/fonts.scss).
Maybe we should also document how to override the things you can by using src/styles/fonts.scss/src/fonts/katex.scss directly and setting some variables, especially if you already have SCSS in your build chain.
Originally I was thinking one thinking of a new top section, titled something like "simple overrides with SCSS". But it might make sense in each section where it's relevant (the last two) how you can modify by using src/style/*scss instead of dist/*css.
In other words, we should document the actual user-visible "feature" of this PR. 🙂 (though a release won't actually trigger with a chore commit message...)
I could also take a stab at writing this if you'd prefer.
There was a problem hiding this comment.
I could also take a stab at writing this if you'd prefer.
Yes please, or at least part of it so I would better understand the desired outcome and could do it myself in other chapters.
I wasn't sure if that should be a chore, but CSS artifact hasn't changed much so I've decided to name it this way, please let me know if I need to reword the commit.
There was a problem hiding this comment.
I wondered this too, but I think in the end chore is the best description.
I added some description about how to override variables for users of Sass. Could you review? Here's a rendered version. Then I think this is good to go.
There was a problem hiding this comment.
Looks good to me.
|
🎉 This PR is included in version 0.16.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What is the previous behavior before this PR?
Less was used to build CSS
What is the new behavior after this PR?
Sass is used to build CSS
Things to consider:
font-familyproperty.stylelintonce because it doesn't recognizenthand if I update it to the latest version, it generates a ton of errors, and fixing them could be way out of scope of migration.Closes #3116