Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #26

Merged
merged 9 commits into from
Mar 3, 2022
Merged

Refactoring #26

merged 9 commits into from
Mar 3, 2022
+84 −22

Conversation

KS1019
Copy link
Owner

@KS1019 KS1019 commented Mar 3, 2022

No description provided.

@KS1019 KS1019 self-assigned this Mar 3, 2022
@github-actions
Copy link

github-actions bot commented Mar 3, 2022 •
edited
Loading

SwiftLint found issues

Severity File Reason
Warning Files+Extensions.swift:5 Line should be 120 characters or less: currently 137 characters (line_length)
Warning Package.swift:9 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:31 Collection literals should not have trailing commas. (trailing_comma)
Warning Package.swift:40 Collection literals should not have trailing commas. (trailing_comma)
Warning List.swift:36 Line should be 120 characters or less: currently 123 characters (line_length)
Warning List.swift:66 Line should be 120 characters or less: currently 157 characters (line_length)
Warning Utils.swift:33 Function body should span 40 lines or less excluding comments and whitespace: currently spans 50 lines (function_body_length)
Warning Utils.swift:109 Variable name should be between 3 and 40 characters long: 'to' (identifier_name)
Warning Utils.swift:125 Line should be 120 characters or less: currently 150 characters (line_length)
Warning Utils.swift:129 Line should be 120 characters or less: currently 142 characters (line_length)
Warning Utils.swift:139 Line should be 120 characters or less: currently 177 characters (line_length)
Warning Utils.swift:140 Line should be 120 characters or less: currently 164 characters (line_length)
Warning Utils.swift:112 FIXMEs should be resolved (This will fail when Bookmarkle...). (todo)
Warning Utils.swift:113 FIXMEs should be resolved (Bookmarklets/ are assumed to b...). (todo)
Warning Utils.swift:116 FIXMEs should be resolved (This can be super slow as the ...). (todo)

Generated by 🚫 Danger Swift against bc20735

@KS1019 KS1019 marked this pull request as ready for review March 3, 2022 02:36
@KS1019 KS1019 merged commit 2988492 into main Mar 3, 2022
@KS1019 KS1019 deleted the refactoring-part-2 branch March 3, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KS1019 KS1019

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KS1019