Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sync from html & fix list #20

Merged
merged 7 commits into from
Feb 22, 2022
Merged

Allow sync from html & fix list #20

merged 7 commits into from
Feb 22, 2022

Conversation

KS1019
Copy link
Owner

@KS1019 KS1019 commented Feb 22, 2022

This PR will:

  • allow syncing from bookmarks.html exported from safari
  • fix list to look for js files in .Hondana/Bookmarklets/
  • add new tests

@KS1019 KS1019 self-assigned this Feb 22, 2022
@github-actions
Copy link

github-actions bot commented Feb 22, 2022 •
edited
Loading

SwiftLint found issues

Severity File Reason
Error List.swift:14 Variable name should be between 3 and 40 characters long: 'w' (identifier_name)
Warning List.swift:9 Line should be 120 characters or less: currently 151 characters (line_length)
Warning List.swift:46 Line should be 120 characters or less: currently 157 characters (line_length)
Warning List.swift:33 Lines should not have trailing whitespace. (trailing_whitespace)
Warning List.swift:37 Lines should not have trailing whitespace. (trailing_whitespace)
Warning List.swift:47 Lines should not have trailing whitespace. (trailing_whitespace)
Warning HondanaTests.swift:31 Line should be 120 characters or less: currently 130 characters (line_length)
Warning HondanaTests.swift:13 Lines should not have trailing whitespace. (trailing_whitespace)
Warning HondanaTests.swift:18 Lines should not have trailing whitespace. (trailing_whitespace)
Warning HondanaTests.swift:22 Lines should not have trailing whitespace. (trailing_whitespace)
Warning HondanaTests.swift:28 Lines should not have trailing whitespace. (trailing_whitespace)
Warning HondanaTests.swift:41 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:18 Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
Error Sync.swift:35 Force tries should be avoided. (force_try)
Error Sync.swift:39 Force tries should be avoided. (force_try)
Error Sync.swift:42 Force tries should be avoided. (force_try)
Error Sync.swift:43 Force tries should be avoided. (force_try)
Error Sync.swift:45 Force tries should be avoided. (force_try)
Error Sync.swift:64 Force tries should be avoided. (force_try)
Error Sync.swift:65 Force tries should be avoided. (force_try)
Error Sync.swift:72 Force tries should be avoided. (force_try)
Error Sync.swift:113 Force tries should be avoided. (force_try)
Error Sync.swift:121 Force tries should be avoided. (force_try)
Error Sync.swift:122 Force tries should be avoided. (force_try)
Error Sync.swift:124 Force tries should be avoided. (force_try)
Error Sync.swift:128 Force tries should be avoided. (force_try)
Error Sync.swift:132 Force tries should be avoided. (force_try)
Error Sync.swift:133 Force tries should be avoided. (force_try)
Error Sync.swift:135 Force tries should be avoided. (force_try)
Error Sync.swift:147 Force tries should be avoided. (force_try)
Warning Sync.swift:32 Function body should span 40 lines or less excluding comments and whitespace: currently spans 50 lines (function_body_length)
Warning Sync.swift:108 Variable name should be between 3 and 40 characters long: 'to' (identifier_name)
Warning Sync.swift:8 Line should be 120 characters or less: currently 151 characters (line_length)
Error Sync.swift:39 Line should be 120 characters or less: currently 222 characters (line_length)
Warning Sync.swift:59 Line should be 120 characters or less: currently 125 characters (line_length)
Warning Sync.swift:124 Line should be 120 characters or less: currently 151 characters (line_length)
Warning Sync.swift:128 Line should be 120 characters or less: currently 143 characters (line_length)
Warning Sync.swift:138 Line should be 120 characters or less: currently 177 characters (line_length)
Warning Sync.swift:139 Line should be 120 characters or less: currently 164 characters (line_length)
Warning Sync.swift:166 Line should be 120 characters or less: currently 133 characters (line_length)
Error Sync.swift:167 Line should be 120 characters or less: currently 211 characters (line_length)
Warning Sync.swift:111 FIXMEs should be resolved (This will fail when Bookmarkle...). (todo)
Warning Sync.swift:112 FIXMEs should be resolved (Bookmarklets/ are assumed to b...). (todo)
Warning Sync.swift:115 FIXMEs should be resolved (This can be super slow as the ...). (todo)
Warning Sync.swift:9 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:12 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:31 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:49 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:61 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:76 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:87 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:90 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:97 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:107 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:114 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:136 Lines should not have trailing whitespace. (trailing_whitespace)
Warning Sync.swift:168 Lines should not have trailing whitespace. (trailing_whitespace)

Generated by 🚫 Danger Swift against 3e4b964

@KS1019 KS1019 marked this pull request as draft February 22, 2022 08:56
@KS1019 KS1019 marked this pull request as ready for review February 22, 2022 09:05
@KS1019 KS1019 merged commit 1f8c627 into main Feb 22, 2022
@KS1019 KS1019 deleted the allow-sync-from-html branch February 22, 2022 09:06
@KS1019 KS1019 mentioned this pull request Feb 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KS1019 KS1019

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KS1019