Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(perf): use request streams to reduce memory usage #336

Merged
merged 1 commit into from
Oct 5, 2021
Merged

fix(perf): use request streams to reduce memory usage #336

merged 1 commit into from
Oct 5, 2021

Conversation

JustinBeckwith
Copy link
Owner

@JustinBeckwith JustinBeckwith commented Oct 5, 2021 •
edited
Loading

Before this fix, max mem usage scanning nodejs-ai-platform was ~3GB. After, it was ~0.5GB.

Before:

npm run docs-test   513.31s  user 29.49s system 108% cpu 8:19.94 total
avg shared (code):         0 KB
avg unshared (data/stack): 0 KB
total (sum):               0 KB
max memory:                3016600 KB
page faults from disk:     0
other page faults:         9671141

After:

npm run docs-test   520.45s  user 26.06s system 110% cpu 8:14.96 total
avg shared (code):         0 KB
avg unshared (data/stack): 0 KB
total (sum):               0 KB
max memory:                561248 KB
page faults from disk:     0
other page faults:         7287496

@JustinBeckwith JustinBeckwith merged commit 6e33b39 into main Oct 5, 2021
@JustinBeckwith JustinBeckwith deleted the nomem branch October 5, 2021 03:38
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

🎉 This PR is included in version 2.14.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustinBeckwith @bcoe