Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow system to generate random port when desired (#319) #328

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

rrthomas
Copy link
Contributor

No description provided.

@rrthomas
Copy link
Contributor Author

To answer @JustinBeckwith's question on #320, this indeed means the underlying web server uses its own logic to grab a random port. This functionality is, at root, implemented in the TCP/IP stack (passing port 0 to bind()). In linkinator this is handled by startWebServer() in server.ts.

@JustinBeckwith
Copy link
Owner

@rrthomas apologies for the delay! This would fix #319, right?

@JustinBeckwith JustinBeckwith merged commit 7b9d493 into JustinBeckwith:main Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

🎉 This PR is included in version 2.14.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants