Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Handle prediction that returns a confidence interval (#77)" #80

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

andreasnoack
Copy link
Member

@andreasnoack andreasnoack commented Jan 17, 2019

This reverts commit a64cb50.

As discussed in #77. Once this has been merged, I'll make a new release and should be able to finish the predict behavior without any rush. (@nalimilan we already require DataFrames 0.15 which includes the two argument eachcol methods, see JuliaData/DataFrames.jl@dcac4bc.)

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #80 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   91.79%   91.77%   -0.03%     
==========================================
  Files           7        7              
  Lines         378      377       -1     
==========================================
- Hits          347      346       -1     
  Misses         31       31
Impacted Files Coverage Δ
src/statsmodel.jl 88.23% <100%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0038211...a8b3c54. Read the comment docs.

@andreasnoack andreasnoack merged commit a28838f into master Jan 17, 2019
@andreasnoack andreasnoack deleted the an/revert branch January 17, 2019 07:15
@nalimilan
Copy link
Member

(@nalimilan we already require DataFrames 0.15 which includes the two argument eachcol methods, see JuliaData/DataFrames.jl@dcac4bc.)

Yes we require it because I committed that change directly on your PR before merging. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants