Explicitly ask for column names in evalcontrasts when calling eachcol. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the doctests are failing but given the expected arrival of #71, I don't think it's worth fixing them. |
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 91.77% 91.94% +0.17%
==========================================
Files 7 7
Lines 377 385 +8
==========================================
+ Hits 346 354 +8
Misses 31 31
Continue to review full report at Codecov.
|
andreasnoack
force-pushed
the
an/nowarn
branch
from
916b35c to
d6fa033
Compare
nalimilan
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removes a warning which broke the GLM doctests. I plan to make a bugfix release once this is in.