0.7patch #72
Merged
0.7patch #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
- Coverage 94.7% 93.03% -1.68%
==========================================
Files 6 6
Lines 302 287 -15
==========================================
- Hits 286 267 -19
- Misses 16 20 +4
Continue to review full report at Codecov.
|
ararslan
reviewed
Sep 10, 2018
.travis.yml
Outdated
|
|
||
| after_script: | ||
| # push coverage results to Codecov and Coveralls | ||
| - julia -e 'using Pkg, StatsModels; cd(joinpath(dirname(pathof(StatsModels)), "..")); Pkg.add("Coverage"); using Coverage; Codecov.submit(process_folder()); Coveralls.submit(process_folder())' |
There was a problem hiding this comment.
This can actually be simplified to just
- julia -e 'using Pkg; Pkg.add("Coverage"); using Coverage; Coveralls.submit(process_folder()); Codecov.submit(process_folder())'
ararslan
reviewed
Sep 10, 2018
.travis.yml
Outdated
| - julia -e 'using Pkg, StatsModels; cd(joinpath(dirname(pathof(StatsModels)), "..")); Pkg.add("Coverage"); using Coverage; Codecov.submit(process_folder()); Coveralls.submit(process_folder())' | ||
| # Update the documentation | ||
| - julia -e 'using Pkg; Pkg.add("Documenter")' | ||
| - julia -e 'using StatsModels; ENV["DOCUMENTER_DEBUG"] = "true"; include(joinpath(dirname(pathof(StatsModels)), "..", "docs", "make.jl"))' |
There was a problem hiding this comment.
Similarly this need only be
- julia -e 'using Pkg; include(joinpath("docs", "make.jl"))'The DOCUMENTER_DEBUG environment variable can be set explicitly as a Travis environment variable.
nalimilan
approved these changes
Sep 11, 2018
|
Thanks! |
|
And thanks for the review and the corrections. |
|
I second releasing a patch version with the missed 0.7 deprecation fix. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One change for Julia v0.7 in
src/modelmatrix.jlthat I had missed earlier. While making that change I also brought the CI script files up to date.I would really appreciate this PR being merged as it will allow the
MixedModelspackage to pass tests on Julia 1.0. I know that @kleinschmidt has the Terms 2.0 branch for the future of StatsModels. This fix is just so that I can release a new version of MixedModels