Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes for 0.7 #69

Merged
merged 11 commits into from
Jul 6, 2018
Merged

fixes for 0.7 #69

merged 11 commits into from
Jul 6, 2018

Conversation

kleinschmidt
Copy link
Member

@kleinschmidt kleinschmidt commented Jun 28, 2018 •
edited
Loading

WIP. Starting with running femtocleaner.

@codecov-io
Copy link

codecov-io commented Jun 29, 2018 •
edited
Loading

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files           6        6           
  Lines         362      362           
=======================================
  Hits          340      340           
  Misses         22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e03d866...e028281. Read the comment docs.

kleinschmidt and others added 6 commits June 29, 2018 15:19
@kleinschmidt
don't test on 0.6
e028281
@matthieugomez @kleinschmidt
msng -> nonmissing (#70)
33f7b9c 
* msng -> nonmissing

msng had a confusing name and a wrong definition in doc. I renamed the vector and corrected the doc.

* better doc
@kleinschmidt @dmbates
bump version to 0.7-beta
fbc7a5d
@femtocleaner @dmbates
Fix deprecations
7b55263
@kleinschmidt @dmbates
fix implicit broadcast assignment deprecation
8971ec0
@kleinschmidt @dmbates
don't test on 0.6
f58944d
@dmbates
Copy link
Contributor

dmbates commented Jul 5, 2018

I was able to rebase this branch on master painlessly (a first for me!) and it now passes tests on v0.7.0-beta. The only remaining warning is

┌ Warning: `reduce(op, v0, itr)` is deprecated, use `reduce(op, itr; init=v0)` instead
│   caller = coefnames(::ModelFrame) at modelframe.jl:260
└ @ StatsModels modelframe.jl:260

and I think that can be changed if the REQUIRE file lists julia 0.7.0-beta. Shall I go ahead and make those changes?

@kleinschmidt
Copy link
Member Author

Sounds good, thanks @dmbates, and congratulations on a painless rebase :) I'll let you push your rebased changes here.

@dmbates
Copy link
Contributor

dmbates commented Jul 6, 2018

Travis failures are because .travis.yml proposes to test on version 0.7 which doesn't exist yet.

@kleinschmidt
Copy link
Member Author

kleinschmidt commented Jul 6, 2018 via email

@dmbates
Copy link
Contributor

dmbates commented Jul 6, 2018

I can't see what is causing the difference but Travis succeeds on nightly and fails on 0.7.

@dmbates dmbates merged commit c75823d into master Jul 6, 2018
@dmbates
Copy link
Contributor

dmbates commented Jul 6, 2018

From the discussion on slack it looks as if the failures are harmless so I will merge this.

@ararslan ararslan deleted the dfk/0.7-deprecations branch July 6, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kleinschmidt @codecov-io @dmbates @matthieugomez