Add julia keyword argument to deploydocs
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will be required in the future instead of automatically defaulting to `julia = "nightly" (see JuliaDocs/Documenter.jl#712, JuliaDocs/Documenter.jl#526). This commit adds `julia = "nightly"` to `Documenter.deploydocs`.
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 93.85% 93.85%
=======================================
Files 6 6
Lines 358 358
=======================================
Hits 336 336
Misses 22 22Continue to review full report at Codecov.
|
|
@fredrikekre Thanks for the automated PRs! Though wouldn't "0.6" be a better choice in general, given that "nightly" frequently breaks? That would be the occasion to fix packages. |
|
I agree that that is better in general, and it was only ~40 or so registered packages that didn't specify this kwarg at all, most others specify 0.6. I opted for |
|
okay to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
This is an automated pull request submitted by
@fredrikekreto update your call doDocumenter.deploydocs. Thejuliakeyword argument toDocumenter.deploydocswill be required in the future instead of defaulting tojulia = "nightly"(see JuliaDocs/Documenter.jl#712, JuliaDocs/Documenter.jl#526). Please take a look at this PR and ping@fredrikekreif you have any questions.