Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique from categoricalarrays 0.3.8 #55

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Conversation

kleinschmidt
Copy link
Member

CategoricalArrays 0.3.8 changes unique to return values in the order they are encountered, rather than the natural (sorted) order. This uses intersect(levels(x), unique(x)) to impose the order of levels on the values returned by unique.

@kleinschmidt kleinschmidt requested a review from nalimilan April 16, 2018 23:28
@codecov-io
Copy link

codecov-io commented Apr 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@82d6a72). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #55   +/-   ##
=========================================
  Coverage          ?   94.59%           
=========================================
  Files             ?        5           
  Lines             ?      333           
  Branches          ?        0           
=========================================
  Hits              ?      315           
  Misses            ?       18           
  Partials          ?        0
Impacted Files Coverage Δ
src/modelframe.jl 93.24% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d6a72...e612929. Read the comment docs.

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Too bad we relied on this here, I should probably have checked (and we should add upper bounds in METADATA).

@ararslan ararslan merged commit 9bbc2a7 into master Apr 17, 2018
@ararslan ararslan deleted the dfk/categorical-unique branch April 17, 2018 07:32
@nalimilan
Copy link
Member

JuliaLang/METADATA.jl#14303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants