fix tests on nightly #283
Merged
fix tests on nightly #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that nightly changes the behavior of
@test_brokento error if the returned value is not a boolean or no error is thrown. We had three tests with behavior like this: two where the behavior ofdrop_termchanged from previous (pre 0.6) version to not check whether the term was present at all (seems fine and no one has complained about it in 4 years so it's okay to change the semantics), and another where a fix to one issue caused a previously erroring path to no longer error. I restored the error with a specific method to catch the footgun of passing:x => DummyCoding(instead of:x => DummyCoding()) earlier.This doesn't need to block 0.7 release.