relax some checks on eltypes for contrasts and add tests #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palday
reviewed
Sep 21, 2021
|
The x86 failure might be a CSV issue (JuliaData/CSV.jl#913) |
palday
approved these changes
Oct 27, 2021
|
@kleinschmidt patch-bump (0.6.29) and merge? |
nalimilan
approved these changes
Feb 14, 2022
|
In theory I think the rule is to bump the minor version when dropping support for older Julia versions, in case one needs to do another patch release to fix a bug there too. But making a breaking release that requires updating version bounds for all dependencies would be annoying. |
|
Seems unlikely that we'd need to backport things to make another release that supports unsupported Julia versions, as 1.6 is LTS. |
|
I'd like to merge the fix in #252 first, then merge that here, make sure CI still passes, adn then we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To maintain compat with Julia 1.0, I had to write the tests using CSV to round trip some strings...that should produce
StringNtypes for versions where that's possible and do something reasonable otherwise.fixes #236