Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typos #284

Closed
musvaage opened this issue Mar 18, 2023 · 1 comment · Fixed by #285
Closed

typos #284

musvaage opened this issue Mar 18, 2023 · 1 comment · Fixed by #285

Comments

@musvaage
Copy link
Contributor

musvaage commented Mar 18, 2023 •
edited
Loading

omitted

$ grep -n ommitted StatsModels.jl/test/traits.jl
42:            # intercept is present even if it's not specified or even ommitted.
$

one hyphenated
one absent a hyphen and missing an e

my suggestion is absent a hyphen in both instances

$ ed -s StatsModels.jl/src/StatsModels.jl <<<'21p'
    #re-export from StatsBase:
$ ed -s StatsModels.jl/src/StatsModels.jl <<<'51p'
    lag, lead, # Rexported from ShiftedArrays
$
@musvaage musvaage mentioned this issue Mar 19, 2023
Merged
@musvaage
Copy link
Contributor Author

@ararslan

Any preference here?

src/StatsModels.jl

reexport or re-export

Reexported or Re-exported

The linked to PR used unhyphenated strings but it can be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix typos
1 participant
@musvaage