Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export hasintercept and omitsintercept? #276

Closed
Tracked by #271
matthieugomez opened this issue Jan 31, 2023 · 2 comments · Fixed by #281
Closed
Tracked by #271

Export hasintercept and omitsintercept? #276

matthieugomez opened this issue Jan 31, 2023 · 2 comments · Fixed by #281

Comments

@matthieugomez
Copy link
Contributor

Because they are not exported, I am redefining both in FixedEffectModels. It might be useful for other packages as well.
@matthieugomez matthieugomez changed the title Could this package export hasintercept and omitsintercept? Export hasintercept and omitsintercept? Jan 31, 2023
@ararslan
Copy link
Member

I believe a number of packages are assuming they're public, e.g. GLM and Survival off the top of my head, so definitely +1 for exporting.

@kleinschmidt
Copy link
Member

yeah we shoudl be exporting these

@kleinschmidt kleinschmidt mentioned this issue Feb 10, 2023
Open
5 tasks
@kleinschmidt kleinschmidt mentioned this issue Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

export (has|omits)(intercept|response) JuliaStats/StatsModels.jl
3 participants
@kleinschmidt @matthieugomez @ararslan