Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking changes to contrasts #175

Closed
3 tasks
kleinschmidt opened this issue Feb 22, 2020 · 3 comments · Fixed by #273
Closed
3 tasks

breaking changes to contrasts #175

kleinschmidt opened this issue Feb 22, 2020 · 3 comments · Fixed by #273
Milestone
0.7

Comments

@kleinschmidt
Copy link
Member

To be considered for the next breaking release (as discussed briefly in #172):

  • use keyword arguments for contructors
  • error on missing labels for hypothesis/contrasts coding
  • more specific termnames for contrasts
@kleinschmidt kleinschmidt added this to the 0.7 milestone Feb 22, 2020
@palday
Copy link
Member

palday commented May 20, 2022

xref #251 -- we should probably support arbitrary matrix containers and eltypes to allow e.g. sparse matrices in single precision.

@ararslan
Copy link
Member

AFAICT that shouldn't actually be breaking though.

@palday
Copy link
Member

palday commented May 20, 2022

@ararslan I mostly agree, changes to the type parameters (and I suspect that we should maybe have the storage type as a type parameter) can have all sorts of wonky knock-on effects even if most code will run without change.

This was referenced Jan 24, 2023
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7
Development

Successfully merging a pull request may close this issue.

Allow arbitrary storage for ContrastsMatrix and other contrasts breakage JuliaStats/StatsModels.jl
3 participants
@kleinschmidt @palday @ararslan