Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with update to NumericalExtensions (#44) #46

Merged
merged 1 commit into from
Jan 3, 2014

Conversation

lendle
Copy link
Contributor

@lendle lendle commented Dec 29, 2013

Fixes #44

@kmsquire
Copy link

Just a comment that this fixes the problem.

@lindahua, is there a reason these are not exported in the latest version? I haven't looked deeply into their use, but you mentioned that you're moving away from using functors (presumably to make things easier to move into base). Are they generally easy to remove from package code?

Cheers!

@dmbates
Copy link
Contributor

dmbates commented Jan 3, 2014

Sorry to have been so late in replying to these issues, I was ill during December and also was occupied with a death in the family.

In b5b812e I committed an alternative approach which is to use the explicit types Functor{1} etc. instead of the typealiases UnaryFunctor, etc.

I should have checked for pull requests first. Any objections to staying with the current commit and closing this pull request?

lindahua added a commit that referenced this pull request Jan 3, 2014
Fix issue with update to NumericalExtensions (#44)
@lindahua lindahua merged commit 80ec0e3 into JuliaStats:master Jan 3, 2014
@lindahua
Copy link
Contributor

lindahua commented Jan 3, 2014

I think these should be exported. Thanks.

@lindahua
Copy link
Contributor

lindahua commented Jan 3, 2014

Oh, I was considering these as a patch to NumericExtensions. @dmbates: please feel free to revert my merge if you think the original version was better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumericExtensions update broke GLM
4 participants