Doc and README.md fixes #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
reviewed
May 20, 2017
README.md
Outdated
| [](http://pkg.julialang.org/?pkg=GLM) | ||
| [](http://pkg.julialang.org/?pkg=GLM) | ||
|
|
||
| ## Older versions | ||
|
|
||
| This documentation applies to the current version of GLM.jl, which requires Julia 0.5 or later. |
There was a problem hiding this comment.
Isn't is a safe assumption that any documentation refers to the most recent version? Seems to me that this older versions section could be removed altogether.
There was a problem hiding this comment.
Yeah, and that's always annoying to have to update the reference to Julia 0.5 (which we will probably forget to do). Updated.
Remove list of extractors which are documented in StatsBase (the docstrings where out of sync for coeftable). Remove outdated references in README and add new badges.
ararslan
approved these changes
May 20, 2017
|
merge? |
|
Thanks for the reminder, @tlnagy. I guess Milan and I forgot about this. |
mkborregaard
pushed a commit
to mkborregaard/GLM.jl
that referenced
this pull request
Jun 8, 2017
Remove list of extractors which are documented in StatsBase (the docstrings where out of sync for coeftable). Remove outdated references in README and add new badges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove list of extractors which are documented in StatsBase (the
docstrings where out of sync for coeftable).
Remove outdated references in README and add new badges.
The docs don't seem to be used anywhere so it doesn't really matter. At some point we should move all documentation from README.md to a proper Documenter manual (#138 is a good step toward that goal).