-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Dynamic Obstacle env, I closed the last one because my commits got a bit messy. #46
Adding Dynamic Obstacle env, I closed the last one because my commits got a bit messy. #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
How about adding a GIF in readme?
src/envs/dynamicobstacles.jl
Outdated
flag = 0 | ||
#flag indicated whether | ||
#1)the new-position of the kth obstacle overlaps the new-positions of [1,k-1] obstacles | ||
#2)the new-position of an obstacle is the same as it's old position |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can allow the obstacle to stay the same as its old position now? Considering the extreme case that the last obstacle is surrounded by 8 obstacles (I know is really a corner case...), it will never break out if we don't allow it to be the same with its old position.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll change this tmrow and attach a GIF to the readme as well :)
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 37.54% 31.16% -6.39%
==========================================
Files 13 14 +1
Lines 293 353 +60
==========================================
Hits 110 110
- Misses 183 243 +60
Continue to review full report at Codecov.
|
@findmyway I have made the final changes and fixed a few errors. 😃 |
Cool! One final minor issue. It seems that in your GIF the obstacle may be placed in the same position of the GOAL. Could you add a check to avoid this case? |
obstacles shouldn't spawn or relocate on goal position
@findmyway Ofcourse. Done |
I think this should work now, but tell me if anything is wrong