Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for actions #40

Merged
merged 3 commits into from
Oct 11, 2020
Merged

Add support for actions #40

merged 3 commits into from
Oct 11, 2020

Conversation

Sid-Bhatia-0
Copy link
Member

  1. Creating an abstract type AbstractGridWorldAction for actions.
  2. Adding a default implementation for get_actions that can be extended by specific environments.
  3. Fixed variable name from dir to action since TURN_LEFT and TURN_RIGHT are actions.

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #40 into master will decrease coverage by 0.12%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   37.67%   37.54%   -0.13%     
==========================================
  Files          13       13              
  Lines         292      293       +1     
==========================================
  Hits          110      110              
- Misses        182      183       +1     
Impacted Files Coverage Δ
src/actions.jl 100.00% <ø> (ø)
src/abstract_grid_world.jl 77.77% <50.00%> (-4.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae5901...f3f636e. Read the comment docs.

@findmyway findmyway merged commit f3e65e4 into JuliaReinforcementLearning:master Oct 11, 2020
@findmyway
Copy link
Member

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants