Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #39

Merged
merged 4 commits into from
Oct 11, 2020
Merged

Refactor #39

merged 4 commits into from
Oct 11, 2020

Conversation

Sid-Bhatia-0
Copy link
Member

Refactoring out directions and actions from objects.jl into their own respective files. objects.jl should be kept only for defining objects.

Also exported the relevant names.

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   37.67%   37.67%           
=======================================
  Files          11       13    +2     
  Lines         292      292           
=======================================
  Hits          110      110           
  Misses        182      182           
Impacted Files Coverage Δ
src/GridWorlds.jl 100.00% <ø> (ø)
src/objects.jl 17.24% <ø> (-24.23%) ⬇️
src/actions.jl 100.00% <100.00%> (ø)
src/directions.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78a830...923c87f. Read the comment docs.

@findmyway findmyway merged commit 1ae5901 into JuliaReinforcementLearning:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants