Inline equations fix #947
Inline equations fix #947
Conversation
epolack
force-pushed
the
fix-docs
branch
3 times, most recently
from
b0e5686 to
3693581
Compare
epolack
force-pushed
the
fix-docs
branch
2 times, most recently
from
a951bcd to
4b97817
Compare
Have not looked at the details, but as far as I understand it with DocStringExtensions we don't need to do the signatures by hand any more, but maybe we use it wrongly. |
|
Oh, that's it! I did not noticed it was imported; thanks! I'll do a pass to remove the signatures we have. |
Thanks ! But don't do it blindly before checking that DocStringExtensions does not accidentially drop some information we have in the current signatures. |
|
Sure :) |
|
I played a bit, but I was not able to selectively replace some signatures and by default keep others. So, maybe keep it that way for now; unless you have an idea… (BTW, the CI fails catastrophically; no idea why.) |
|
The culprit was this change is Spglib. It seems to be an upstream issue. |
@epolack What you did was not limiting the version from below, so 0.0.0 would be valid, which can be a problem 😄.
|
@epolack Great catch ! Thanks very much ! |
PR #946 introduced a bug where inline math was not rendered properly, as modifying
:texoverwrote the default configuration. There were also minor style issues that I have corrected.However, I have noticed signatures issues that I do not understand. Examples here and there.
Signatures done by hand are not taken into accounts, and some are duplicated.