merge the two versions of randmtzig_{randn,exprnd} #8875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems to improve slightly (by about 5%) randn() methods working with the global RNG, which now match the speed of those working with a (non-global) MersenneTwister instance.
|
I think this is right, but could try to benchmark them against the old versions just to make sure that they are not slower? |
|
I only tested |
|
I benchmarked both, and they are faster than before. |
|
Great. Then there shouldn't be a problem with merging this. |
jakebolewski
added a commit
that referenced
this pull request
Nov 7, 2014
waTeim
pushed a commit
to waTeim/julia
that referenced
this pull request
Nov 23, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those functions are now written without
@eval: I guess this was used to work around a missingrand(::MersenneTwister)method, but I may have missed something (it seems to have been written in 1cbb6d0, by @andreasnoack: can you confirm this change is OK?).My understanding is that the speed improvements come from that the global RNG is accessed only once (as an argument of the function), instead of few times in
randmtzig_randn(viarand()).