Fix some issues with new Dict constructors #8627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
simonster
commented
Oct 8, 2014
simonster
commented
- If either the keys or values have the same type for all Pairs, use that type
- Deprecations for removed constructors
| Dict{K,V}(kv::((K,V)...,)) = Dict{K,V}(kv) | ||
| Dict{K }(kv::((K,Any)...,)) = Dict{K,Any}(kv) | ||
| Dict{V }(kv::((Any,V)...,)) = Dict{Any,V}(kv) | ||
| Dict (kv::((Any,Any)...,)) = Dict{Any,Any}(kv) |
There was a problem hiding this comment.
This is actually covered by the generic Dict(kv).
- If either the keys or values has the same type for all Pairs, use that type - Deprecations for removed constructors
simonster
force-pushed
the
sjk/dict-cleanup
branch
from
a6715c6 to
1e96ba9
Compare
|
I could also add a deprecation warning for the |
JeffBezanson
added a commit
that referenced
this pull request
Oct 8, 2014
Fix some issues with new Dict constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.