-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix overlapping definitions of Base.active_module
and REPL.active_module
#55316
Conversation
a1c40de
to
63493b2
Compare
This is hopefully ok now.
|
@nanosoldier |
The package evaluation job you requested has completed - possible new issues were detected. |
fix overlapping definitions of `Base.active_module` and `REPL.active_module`
63493b2
to
9a564d4
Compare
OK there was one package test failure that was actually expecting a qualified name, which is preferred since it is less state-dependent, so I switched function printing back to something more compatible with |
…module` (JuliaLang#55316) also avoid calling `active_module` from low-level printing functions fix JuliaLang#54888
I'm hoping this will fix #54888 but I haven't been able to reproduce it so maybe somebody else can confirm.