Cleanup MemoryRef tests #54681
Merged
Cleanup MemoryRef tests #54681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
the
re-land
oscardssmith
force-pushed
the
os/fix-cleanup-MemoryRef-tests
branch
from
ed99cdc to
3b1cacc
Compare
aviatesk
added a commit
that referenced
this pull request
Jun 14, 2024
oscardssmith
pushed a commit
that referenced
this pull request
Jun 14, 2024
KristofferC
pushed a commit
that referenced
this pull request
Jun 18, 2024
This reverts commit 42694e7.
KristofferC
pushed a commit
that referenced
this pull request
Jun 18, 2024
This reverts commit a5d6b50.
KristofferC
added a commit
that referenced
this pull request
Jun 25, 2024
This reverts commit 09f450f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aka revert revert #54647. Sorry @Keno for merging with broken tests. Between unrelated failures on windows CI upload and the fact that the errors were all truncated, I missed it.