optimized (and ordered) IdSet code #52114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
performance
vtjnash
force-pushed
the
jn/orderedidset
branch
from
4195b3e to
01c40af
Compare
|
@nanosoldier |
vtjnash
removed
the
needs nanosoldier run
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
|
Are IdDict and IdSet represented in the benchmarks? |
|
IdDict probably is, but is not affected by this PR. IdSet is probably not |
Saves a little bit of memory and some pointer indirections since this does not need resizing.
Makes this an almost-ordered set, using our existing idset optimization for better memory utilization.
vtjnash
force-pushed
the
jn/orderedidset
branch
from
01c40af to
7f981cd
Compare
oscardssmith
removed
the
merge me
mkitti
pushed a commit
to mkitti/julia
that referenced
this pull request
Dec 9, 2023
We have had this smallintset code around for a while for internal purposes, though it was not quite fully general purpose (it didn't have pop). We also have around this tiny global_roots_table (about 1500 entries after building the sysig). This saves about 50% of the space for storing that table. It also optimizes all other IdSet code to not be an inefficient mutable wrapper around an IdDict, but instead be an ordered (by first insertion) set type of its own.
|
Are we thinking of exporting (This just came up on discourse. With the latest optimizations, users can no longer simply use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had this smallintset code around for a while for internal purposes, though it was not quite fully general purpose (it didn't have pop). We also have around this tiny global_roots_table (about 1500 entries after building the sysig). This saves about 50% of the space for storing that table. It also optimizes all other IdSet code to not be an inefficient mutable wrapper around an IdDict, but instead be an ordered (by first insertion) set type of its own.