array: make DimensionMismatch lazy-string friendly
#50079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, the `msg` field of `DimensionMismatch` is typed as `String`. This means lazy strings passed to `DimensionMismatch` are instantly instantiated, defeating the whole purpose of using `LazyString`. This commit tweaks the field type to `AbstractString`. This way, lazy strings get instantiated during the exception handling later on.
aviatesk
added a commit
that referenced
this pull request
Jun 6, 2023
With the same motivation as #50079, this commit is defining the `msg` field of `MissingException` as an `AbstractString` type. By utilizing `LazyString`, it aims to improve the effects of various operations associated with `missing`.
oscardssmith
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the
msgfield ofDimensionMismatchis typed asString. This means lazy strings passed toDimensionMismatchare instantly instantiated, defeating the whole purpose of usingLazyString.This commit tweaks the field type to
AbstractString. This way, lazy strings get instantiated during the exception handling later on.