-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair jl_init. #38950
Repair jl_init. #38950
Conversation
What is a good way to test that this would work with the directory layout of the packaged Julia binaries? Can such packages be created locally? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Yeah, just run |
Not all is good. This isn't working in the package from
|
I'm pretty sure this is not a problem with this PR; that happens on latest |
Right, and it seems to be a difference between what So this is ready to go from my point of view. |
Apparently there is still some problem on windows https://github.com/GunnarFarneback/DynamicallyLoadedEmbedding.jl/runs/1594639460 and macos https://github.com/GunnarFarneback/DynamicallyLoadedEmbedding.jl/runs/1594639444. I should be able to get hold of a windows machine to test locally but macos is out of my reach. |
* Export jl_get_libdir and use it from jl_init to find libjulia. (cherry picked from commit 5cd07f8)
* Export jl_get_libdir and use it from jl_init to find libjulia. (cherry picked from commit 5cd07f8)
* Export jl_get_libdir and use it from jl_init to find libjulia.
* Export jl_get_libdir and use it from jl_init to find libjulia. (cherry picked from commit 5cd07f8)
Cc: @staticfloat
As noted in #38160 (comment),
jl_init
is no longer correctly finding the location oflibjulia
. This PR attempts to fix that by exporting a function that lives inlibjulia
and can reliably introspect itself to find thelibjulia
location, then uses that fromjl_init
.