[loader] Must invalidate .o files when VERSION changes
#38800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't happen that often, (only when `VERSION` changes) but we need to be sensitive to the path to `libjuliainternal.so` changing.
|
Backport? |
|
Sure, but the only case where you'd trigger this is if you built a 1.7 Julia then switched back to a 1.6 branch. Still good to backport though. |
KristofferC
pushed a commit
that referenced
this pull request
Dec 27, 2020
This doesn't happen that often, (only when `VERSION` changes) but we need to be sensitive to the path to `libjuliainternal.so` changing. (cherry picked from commit 6c047cc)
staticfloat
added a commit
that referenced
this pull request
Jan 15, 2021
This doesn't happen that often, (only when `VERSION` changes) but we need to be sensitive to the path to `libjuliainternal.so` changing. (cherry picked from commit 6c047cc)
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
…#38800) This doesn't happen that often, (only when `VERSION` changes) but we need to be sensitive to the path to `libjuliainternal.so` changing.
staticfloat
added a commit
that referenced
this pull request
Dec 23, 2022
This doesn't happen that often, (only when `VERSION` changes) but we need to be sensitive to the path to `libjuliainternal.so` changing. (cherry picked from commit 6c047cc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't happen that often, (only when
VERSIONchanges) but weneed to be sensitive to the path to
libjuliainternal.sochanging.