produce LineInfoNode directly in lowering
#37954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the output of lowering closer to what is actually needed, cutting down on extra conversion work.
JeffBezanson
added
the
compiler:lowering
vtjnash
approved these changes
Oct 9, 2020
|
This change seems to have regressed stacktrace printing for inlined functions, which is quite important e.g. for debugging Cassette. Compare this PR: julia> using Cassette
julia> Cassette.@context NaNCtx;
julia> Cassette.posthook(::NaNCtx, out::Number, f, args...) = isnan(out) ? error("$f$args returned $out") : nothing
julia> checked(f) = Cassette.overdub(NaNCtx(), f)
checked (generic function with 1 method)
julia> checked() do
0 / 0
end
ERROR: div_float(0.0, 0.0) returned NaN
Stacktrace:
[1] error(s::String)
@ Base ./error.jl:33
[2] posthook
@ ~/Documents/julia/bisect.jl:100 [inlined]
[3] overdub
@ ./float.jl:407 [inlined]
[4] overdub
@ ./int.jl:93 [inlined]
[5] overdub(::Cassette.Context{nametype(NaNCtx), Nothing, Nothing, Cassette.var"##PassType#251", Nothing, Nothing}, ::typeof(/), ::Int64, ::Int64)
[...]with 1.5, where 3 and 4 correctly show up as calls to Stacktrace:
[1] error(::String) at ./error.jl:33
[2] posthook at ./REPL[6]:1 [inlined]
[3] / at ./float.jl:407 [inlined]
[4] / at ./int.jl:92 [inlined]
[5] overdub(::Cassette.Context{nametype(NaNCtx),Nothing,Nothing,Cassette.var"##PassType#255",Nothing,Nothing}, ::typeof(/), ::Int64, ::Int64) at /home/simeon/.julia/packages/Cassette/Wjztv/src/overdub.jl:0Is this something that just needs a fix, or would we need to revert this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the output of lowering closer to what is actually needed, cutting down on extra conversion work.
For top-level code and (upcoming) OpaqueClosure, the extra step won't be needed any more, and for methods all that's needed is to insert the correct name in the location info.