Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When defining singleton structs, don't reallocate the ->instance field #37598

Merged
merged 2 commits into from
Sep 17, 2020
Merged

When defining singleton structs, don't reallocate the ->instance field #37598

merged 2 commits into from
Sep 17, 2020

Conversation

Keno
Copy link
Member

@Keno Keno commented Sep 16, 2020

Otherwise, we end up with two singletons for the type, which
confuses many different parts of the runtime system. This
happens quite frequently when using Revise, which likes to
redefine types.

@Keno
When defining singleton structs, don't reallocate the ->instance field
475e23d 
Otherwise, we end up with two singletons for the type, which
confuses many different parts of the runtime system. This
happens quite frequently when using Revise, which likes to
redefine types.
@Keno Keno merged commit 8e3f298 into master Sep 17, 2020
@Keno Keno deleted the kf/toomanysingles branch September 17, 2020 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash Awaiting requested review from vtjnash

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

@timholy timholy Awaiting requested review from timholy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Keno