Add addenv(); a way to add new mappings into Cmd environment blocks.
#37244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
approved these changes
Sep 3, 2020
fredrikekre
reviewed
Sep 4, 2020
|
I'll mention the docstring for withenv(cmd::Cmd, env::Pair{<:AbstractString}...) -> CmdIf having the new function |
staticfloat
force-pushed
the
sf/cmd_env
branch
2 times, most recently
from
8df5431 to
65a4761
Compare
staticfloat
force-pushed
the
sf/cmd_env
branch
from
65a4761 to
9e7f351
Compare
fredrikekre
added
the
needs compat annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses one-half of #37070 as discussed during triage today. One slightly awkward part of this is that
setenv()andaddenv()don't actually mutate thecmdobject passed in, so you must make sure tocmd = addenv(cmd, "FOO" => "bar"). I have made the docs as explicit as possible about this.