JULIA_COPY_STACKS: validate values #33318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good, we should definitely do this. All of our yes/no command line options also do validation, but none of them accept true/false so adding that might sow confusion. |
StefanKarpinski
force-pushed
the
sk/copy-stacks-check
branch
from
2a29374 to
cb01459
Compare
|
I changed it to just do the value validation. |
|
This seems like a viable candidate for a backport. |
KristofferC
pushed a commit
that referenced
this pull request
Oct 3, 2019
(cherry picked from commit 9079472)
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does
getenvwork on Windows? Closes #33317.