Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define / method for adjoint LU rhs. #33209

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Define / method for adjoint LU rhs. #33209

merged 1 commit into from
Sep 11, 2019

Conversation

andreasnoack
Copy link
Member

@andreasnoack andreasnoack mentioned this pull request Sep 10, 2019
Closed
@andreasnoack andreasnoack added bugfix This change fixes an existing bug linear algebra Linear algebra labels Sep 10, 2019
@andreasnoack andreasnoack force-pushed the an/fix33177 branch 3 times, most recently from 9669024 to 21a2f31 Compare September 10, 2019 20:12
@KristofferC
Copy link
Member 

Error in testset ambiguous:
Test Failed at /usr/home/julia/buildbot/worker-tabularasa/tester_freebsd64/build/share/julia/test/ambiguous.jl:169
  Expression: detect_ambiguities(Core, Base; imported=true, recursive=true, ambiguous_bottom=false) == []
   Evaluated: Tuple{Method,Method}[
(/(u::LinearAlgebra.Transpose{T,#s627} where #s627<:(AbstractArray{T,1} where T) where T, A::AbstractArray{T,2} where T) in LinearAlgebra at /usr/home/julia/buildbot/worker/package_freebsd64/build/usr/share/julia/stdlib/v1.4/LinearAlgebra/src/adjtrans.jl:281,
/(A::AbstractArray{T,2} where T, F::LinearAlgebra.Adjoint{#s627,#s626} where #s626<:LinearAlgebra.LU where #s627) in LinearAlgebra at /usr/home/julia/buildbot/worker/package_freebsd64/build/usr/share/julia/stdlib/v1.4/LinearAlgebra/src/lu.jl:427),
(/(u::LinearAlgebra.Adjoint{T,#s627} where #s627<:(AbstractArray{T,1} where T) where T, A::AbstractArray{T,2} where T) in LinearAlgebra at /usr/home/julia/buildbot/worker/package_freebsd64/build/usr/share/julia/stdlib/v1.4/LinearAlgebra/src/adjtrans.jl:280,
/(A::AbstractArray{T,2} where T, F::LinearAlgebra.Adjoint{#s627,#s626} where #s626<:LinearAlgebra.LU where #s627) in LinearAlgebra at /usr/home/julia/buildbot/worker/package_freebsd64/build/usr/share/julia/stdlib/v1.4/LinearAlgebra/src/lu.jl:427),
(/(B::LinearAlgebra.Transpose{T,#s627} where #s627<:(AbstractArray{T,1} where T) where T, adjF::LinearAlgebra.Adjoint{#s627,#s626} where #s626<:LinearAlgebra.Factorization where #s627) in LinearAlgebra at /usr/home/julia/buildbot/worker/package_freebsd64/build/usr/share/julia/stdlib/v1.4/LinearAlgebra/src/factorization.jl:126,
/(A::AbstractArray{T,2} where T, F::LinearAlgebra.Adjoint{#s627,#s626} where #s626<:LinearAlgebra.LU where #s627) in LinearAlgebra at /usr/home/julia/buildbot/worker/package_freebsd64/build/usr/share/julia/stdlib/v1.4/LinearAlgebra/src/lu.jl:427),
(/(adjB::LinearAlgebra.Adjoint{T,#s627} where #s627<:(AbstractArray{T,1} where T) where T, adjF::LinearAlgebra.Adjoint{#s627,#s626} where #s626<:LinearAlgebra.Factorization where #s627) in LinearAlgebra at /usr/home/julia/buildbot/worker/package_freebsd64/build/usr/share/julia/stdlib/v1.4/LinearAlgebra/src/factorization.jl:125,
/(A::AbstractArray{T,2} where T, F::LinearAlgebra.Adjoint{#s627,#s626} where #s626<:LinearAlgebra.LU where #s627) in LinearAlgebra at /usr/home/julia/buildbot/worker/package_freebsd64/build/usr/share/julia/stdlib/v1.4/LinearAlgebra/src/lu.jl:427)] == Any[]

:(

@KristofferC KristofferC mentioned this pull request Sep 11, 2019
Merged
18 tasks
@andreasnoack andreasnoack merged commit 4c8f8fa into master Sep 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the an/fix33177 branch September 11, 2019 09:34
@stevengj
Copy link
Member

Thanks @andreasnoack, sorry I wasn't able to get to this myself.

KristofferC pushed a commit that referenced this pull request Sep 18, 2019
@andreasnoack @KristofferC
Define / method for adjoint LU rhs. (#33209)
9000bd8 
Fixes #33177

(cherry picked from commit 4c8f8fa)
KristofferC pushed a commit that referenced this pull request Sep 19, 2019
@andreasnoack @KristofferC
Define / method for adjoint LU rhs. (#33209)
cd2d247 
Fixes #33177

(cherry picked from commit 4c8f8fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rdiv with transpose of LU on RHS no longer works
4 participants
@andreasnoack @KristofferC @stevengj @fredrikekre