Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JULIA_ENABLE_THREADS feature flag #32685

Merged
merged 3 commits into from
Aug 11, 2019
Merged

Remove JULIA_ENABLE_THREADS feature flag #32685

merged 3 commits into from
Aug 11, 2019

Conversation

mbauman
Copy link
Member

@mbauman mbauman commented Jul 25, 2019

This flag was essentially not documented, not CI'ed, and broken (it hangs in jl_task_get_next at /home/mbauman/julia/src/partr.c:475). Let's strip it out!

@mbauman
Remove JULIA_ENABLE_THREADS feature flag
e377d9f 
This flag was essentially not documented, not CI'ed, and broken (it hangs in `jl_task_get_next at /home/mbauman/julia/src/partr.c:475`). Let's strip it out!
@mbauman
Copy link
Member Author

mbauman commented Jul 26, 2019

Hm, interesting. I think we had previously been running analyzegc without the JULIA_ENABLE_THREADS flag defined!

@JeffBezanson JeffBezanson added building Build system, or building Julia or its dependencies multithreading Base.Threads and related functionality labels Jul 30, 2019
@JeffBezanson
Copy link
Member

I'd like to merge this. Just checking in with @vtjnash @yuyichao

@yuyichao
Copy link
Contributor

Lgtm. Given c11/c++11 I don't think it'll be a big problem supporting threading on a new platform when needed.

@vtjnash
Copy link
Member

vtjnash commented Aug 10, 2019

Yep, I think we should start making threads mandatory. Most CPUs now have them. (Even GPUs?)

@JeffBezanson JeffBezanson merged commit a18ab97 into master Aug 11, 2019
@JeffBezanson JeffBezanson deleted the mb/nonothreads branch August 11, 2019 16:57
vchuravy added a commit that referenced this pull request Dec 3, 2019
@vchuravy
Revert "Remove JULIA_ENABLE_THREADS feature flag (#32685)"
8efb95c 
This reverts commit a18ab97.
@vchuravy
Copy link
Member

vchuravy commented Dec 3, 2019 •
edited
Loading

Turns out we do have an (experimental) target that currently doesn't support threading.
I had to revert this locally for WASM.

(Even GPUs?)

Not in the way you are thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smldis smldis smldis left review comments

@JeffBezanson JeffBezanson JeffBezanson approved these changes

Assignees
No one assigned
Labels
building Build system, or building Julia or its dependencies multithreading Base.Threads and related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mbauman @JeffBezanson @yuyichao @vtjnash @vchuravy @smldis