Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing iszero usage in linalg functions #29668

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Fix missing iszero usage in linalg functions #29668

merged 1 commit into from
Oct 16, 2018

Conversation

dalum
Copy link
Contributor

@dalum dalum commented Oct 16, 2018 •
edited
Loading

This fixes an inconsistency in LinearAlgebra, and could be considered a bugfix, I think. At least with reference to #29665, having the == check instead of iszero makes it hard to create certain user types and have them work with the generic functions.

@andreasnoack andreasnoack added the linear algebra Linear algebra label Oct 16, 2018
@StefanKarpinski StefanKarpinski merged commit 870f995 into JuliaLang:master Oct 16, 2018
@dalum dalum deleted the iszero-linalg branch October 16, 2018 15:08
@HarrisonGrodin HarrisonGrodin mentioned this pull request Mar 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasnoack andreasnoack andreasnoack approved these changes

@StefanKarpinski StefanKarpinski StefanKarpinski approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalum @StefanKarpinski @andreasnoack