Prepare releases to install in julia-<ver> instead of julia-<commit hash> #27752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ash> Solution suggested by @staticfloat Fixes #23452
staticfloat
reviewed
Jun 24, 2018
Make.inc
Outdated
| @@ -167,6 +167,12 @@ else | |||
| JULIA_COMMIT := $(JULIA_VERSION) | |||
| endif | |||
|
|
|||
| # Override `JULIA_COMMIT` to `JULIA_VERSION` if we're on a tagged commit | |||
| ifeq ($(shell git describe --tags --exact-match > /dev/null 2>&1 && echo true),t | |||
There was a problem hiding this comment.
I tested it on release-0.6, and then copy-pasted it for master, which explains it.
haampie
pushed a commit
to haampie/julia
that referenced
this pull request
Jun 24, 2018
…ash> (JuliaLang#27752) * Prepare releases to install in julia-<ver> instead of julia-<commit hash> Solution suggested by @staticfloat Fixes JuliaLang#23452 * Fix accidental linebreak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution suggested by @staticfloat in #23452