build: libgit2 makefile fixes #27737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that operations are happening at the right time, in the right places, in the right order, and with the correct dependencies.
staticfloat
reviewed
Jun 23, 2018
|
|
||
| $(build_prefix)/manifest/libgit2: $(build_datarootdir)/julia/cert.pem # use libgit2 install status | ||
| libgit2-install-mozilla-cacert: $(build_datarootdir)/julia/cert.pem | ||
| get-libgit2: $(SRCCACHE)/cacert-$(MOZILLA_CACERT_VERSION).pem |
There was a problem hiding this comment.
Yes, stashing this in $(SRCCACHE) is an improvement, thanks.
| @@ -23,7 +23,7 @@ $(BUILDDIR)/pcre2-$(PCRE_VER)/build-compiled: $(BUILDDIR)/pcre2-$(PCRE_VER)/buil | |||
| $(MAKE) -C $(dir $<) $(LIBTOOL_CCLD) | |||
| echo 1 > $@ | |||
|
|
|||
| $(BUILDDIR)/pcre2-$(PCRE_VER)/checked: $(BUILDDIR)/pcre2-$(PCRE_VER)/build-compiled | |||
| $(BUILDDIR)/pcre2-$(PCRE_VER)/build-checked: $(BUILDDIR)/pcre2-$(PCRE_VER)/build-compiled | |||
There was a problem hiding this comment.
Is this change intentional? It seems unrelated.
There was a problem hiding this comment.
It is. It was as missed update in 406af98, but I guess nobody really missed it.
haampie
pushed a commit
to haampie/julia
that referenced
this pull request
Jun 24, 2018
Ensure that operations are happening at the right time, in the right places, in the right order, and with the correct dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that operations are happening at the right time, in the right places, in the right order, and with the correct dependencies.