Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move embedding test into the test directory #26123

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Move embedding test into the test directory #26123

merged 1 commit into from
Feb 21, 2018

Conversation

ararslan
Copy link
Member

In preparation for excising all of the examples. This is the only one that's useful as a test.

@ararslan ararslan added test This change adds or pertains to unit tests embedding Embedding Julia using the C API labels Feb 19, 2018
@ararslan ararslan requested a review from staticfloat February 19, 2018 21:43
@ararslan
Copy link
Member Author

AppVeyor isn't working at all, so it would be great if someone who understands Windows/Cygwin could make sure that my change to the AppVeyor configuration makes sense.

.travis.yml Outdated
@@ -148,7 +148,7 @@ script:
- popd
# test that the embedding code works on our installation
- mkdir /tmp/embedding-test &&
make check -C /tmp/julia/share/doc/julia/examples/embedding \
make check -C embedding \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you get rid of the path here? I don't think this works; you still need to give it the path, otherwise it can't find it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't know why I did that. 🙃

@ararslan
Copy link
Member Author

The CI failures are unrelated.

@ararslan
Copy link
Member Author

@staticfloat Want to take another look?

@staticfloat staticfloat merged commit 3835029 into master Feb 21, 2018
@martinholters martinholters deleted the aa/examples branch February 21, 2018 10:01
@StefanKarpinski StefanKarpinski mentioned this pull request Feb 21, 2018
@staticfloat
Copy link
Member

@ararslan I merged this too early apparently; this file needs an update for this to succeed.

ararslan added a commit that referenced this pull request Feb 26, 2018
The file moved from examples/embedding to test/embedding in #26123 but
updates to the examples Makefile where erroneously omitted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embedding Embedding Julia using the C API test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants