-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move embedding test into the test directory #26123
Conversation
AppVeyor isn't working at all, so it would be great if someone who understands Windows/Cygwin could make sure that my change to the AppVeyor configuration makes sense. |
.travis.yml
Outdated
@@ -148,7 +148,7 @@ script: | |||
- popd | |||
# test that the embedding code works on our installation | |||
- mkdir /tmp/embedding-test && | |||
make check -C /tmp/julia/share/doc/julia/examples/embedding \ | |||
make check -C embedding \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you get rid of the path here? I don't think this works; you still need to give it the path, otherwise it can't find it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I don't know why I did that. 🙃
5acd116
to
8934c4e
Compare
The CI failures are unrelated. |
@staticfloat Want to take another look? |
The file moved from examples/embedding to test/embedding in #26123 but updates to the examples Makefile where erroneously omitted.
In preparation for excising all of the examples. This is the only one that's useful as a test.