Add size(::LinearIndices) method #25541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes indexing LinearIndices with an array. This is useful in particular to convert cartesian indices that find() now returns to linear indices.
timholy
approved these changes
Jan 13, 2018
| @@ -418,6 +418,7 @@ module IteratorsMD | |||
| # AbstractArray implementation | |||
| Base.IndexStyle(::Type{LinearIndices{N,R}}) where {N,R} = IndexCartesian() | |||
| Base.axes(iter::LinearIndices{N,R}) where {N,R} = iter.indices | |||
| Base.size(iter::LinearIndices{N,R}) where {N,R} = length.(iter.indices) | |||
There was a problem hiding this comment.
At present we have the recommendation to not implement size for arrays that use non-1 indexing, and so perhaps you should restrict this to OneTo indices. But as part of #24899 (which I will tackle once we stop making breaking changes) that restriction will go away, and I for one do not object if you just keep this the way it is.
There was a problem hiding this comment.
OK. As you want, you're the expert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes indexing
LinearIndiceswith an array. This is useful in particular to convert cartesian indices thatfindnow returns to linear indices.