A few minor miscellaneous testing, doc, and deprecation cleanups #19415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
reviewed
Nov 25, 2016
| mfile = mtime(file) | ||
| mdir = mtime(dir) | ||
| @test abs(now - mfile) <= skew && abs(now - mdir) <= skew && abs(mfile - mdir) <= skew | ||
| @test abs(nowtime - mfile) <= skew && abs(nowtime - mdir) <= skew && abs(mfile - mdir) <= skew |
There was a problem hiding this comment.
This is probably a good thing to do in general but was it causing error anywhere? (Just wondering if there are more places that needs JuliaCI/CoverageBase.jl#21)
There was a problem hiding this comment.
Notice the commit date was actually in September, so this isn't technically necessary for make testall1 to pass any more since your PR, but at the time I authored this it was. And may as well still do it to avoid shadowing.
kshyatt
added
docs
and whitespace in test/test.jl
to avoid "imported binding for now overwritten in module Main"
tkelman
force-pushed
the
tk/misccleanups
branch
from
e11e9cf to
b1fd488
Compare
kshyatt
approved these changes
Nov 26, 2016
StefanKarpinski
approved these changes
Nov 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the first commit, best to view as
58624da?w=1a2356a8?w=1