[RFC] Add eachrsplit iterator #51646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobnissen
added
needs compat annotation
jakobnissen
removed
the
needs compat annotation
jakobnissen
force-pushed
the
eachrsplit
branch
2 times, most recently
from
7967578 to
0ea52a5
Compare
vtjnash
approved these changes
Oct 10, 2023
Unlike rsplit, this iterator returns split substrings right to left, but other- wise it behaves just like eachsplit. This design has been chosen to avoid either a costly double traversal of the input string, or needing a stack to store the strings. Both of these workarounds would lessen the appeal compared to simply using rsplit.
jakobnissen
force-pushed
the
eachrsplit
branch
from
0ea52a5 to
fadedcb
Compare
|
Squashed, otherwise unchanged. I think the ASAN build failure is unrelated to this PR. |
oscardssmith
removed
the
merge me
|
Is there a reason why this wasn't implemented as an |
|
IIRC, this isn't just |
|
I see. So we could implement something like: function Iterators.reverse(itr::Union{SplitIterator,RSplitIterator})
itr.limit <= 0 || throw(ArgumentError("reverse does not support split iterators with limit = $(itr.limit) > 0"))
return (itr isa SplitIterator ? RSplitIterator : SplitIterator)(itr.str, itr.splitter, itr.limit, itr.keepempty)
end |
|
No, even then it is not the same, here's another counter-example: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike rsplit, this iterator returns split substrings right to left, but other- wise it behaves just like eachsplit.
This design has been chosen to avoid either a costly double traversal of the input string, or needing a stack to store the strings. Both of these workarounds would lessen the appeal compared to simply using rsplit.
Closes #45385
Request for comments
rsplit? I believe this is unfortunately necessary.