Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hpmv! to BLAS in stdlib/LinearAlgebra #34211

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Add hpmv! to BLAS in stdlib/LinearAlgebra #34211

merged 1 commit into from
Jan 3, 2020

Conversation

iolaszlo
Copy link
Contributor

No description provided.

dkarrasch
dkarrasch requested changes Dec 28, 2019
View reviewed changes
Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of typos, otherwise LGTM.

stdlib/LinearAlgebra/src/blas.jl Outdated Show resolved Hide resolved
stdlib/LinearAlgebra/src/blas.jl Outdated Show resolved Hide resolved
stdlib/LinearAlgebra/src/blas.jl Outdated Show resolved Hide resolved
@dkarrasch dkarrasch added the linear algebra Linear algebra label Dec 28, 2019
@iolaszlo iolaszlo force-pushed the extend-blas-with-hpmv branch from 698e70c to 4eee1d6 Compare December 28, 2019 21:20
@iolaszlo iolaszlo requested a review from dkarrasch December 28, 2019 22:51
dkarrasch
dkarrasch requested changes Dec 29, 2019
View reviewed changes
stdlib/LinearAlgebra/src/blas.jl Outdated Show resolved Hide resolved
stdlib/LinearAlgebra/src/blas.jl Show resolved Hide resolved
stdlib/LinearAlgebra/test/blas.jl Outdated Show resolved Hide resolved
stdlib/LinearAlgebra/test/blas.jl Outdated Show resolved Hide resolved
@iolaszlo iolaszlo force-pushed the extend-blas-with-hpmv branch from 4eee1d6 to 1235c7b Compare December 29, 2019 15:00
@iolaszlo iolaszlo requested a review from dkarrasch December 29, 2019 15:01
dkarrasch
dkarrasch approved these changes Dec 29, 2019
View reviewed changes
Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. Let's try to get another review before merging it.

@iolaszlo
Copy link
Contributor Author

Neat. Let's try to get another review before merging it.

Thank you for taking the time to review my commits.

@iolaszlo
Copy link
Contributor Author

Could someone please retrigger the win64 and win32 builds, as their failure doesn't seem to be related to the current change. Thank you.

@ViralBShah
Copy link
Member

ViralBShah commented Dec 30, 2019 •
edited
Loading

Retriggered win64. Win32 has been a bit unhappy lately.

@iolaszlo
Copy link
Contributor Author

Retriggered win64. Win32 has been a bit unhappy lately.

Thank you, the win64 build succeeded. Win32 still seems unhappy as it gives a timeout currently. :)

@ararslan ararslan added the needs news A NEWS entry is required for this change label Dec 31, 2019
@dkarrasch
Copy link
Member

@iolaszlo In case you're not yet familiar with the conventions here, the "needs news" label means that you should write an entry in NEWS.md and announce the new feature in the LinearAlgebra section.

@iolaszlo iolaszlo force-pushed the extend-blas-with-hpmv branch from 1235c7b to c25ab8c Compare January 2, 2020 18:56
@iolaszlo
Copy link
Contributor Author

iolaszlo commented Jan 2, 2020

@iolaszlo In case you're not yet familiar with the conventions here, the "needs news" label means that you should write an entry in NEWS.md and announce the new feature in the LinearAlgebra section.

Thank you for the information. I just added the update in NEWS.md and rebased the commit onto the most current master branch.

@JeffBezanson
Copy link
Member

Thanks, great first PR!

@StefanKarpinski
Copy link
Member

Anyone else to review? @andreasnoack or @jiahao care to take a look?

@ViralBShah
Copy link
Member

This is good to merge.

@ViralBShah ViralBShah merged commit 0b034fd into JuliaLang:master Jan 3, 2020
@iolaszlo
Copy link
Contributor Author

iolaszlo commented Jan 3, 2020

Thank you guys for the feedback and the quick responses.

@maleadt maleadt mentioned this pull request Jan 13, 2020
Merged
KristofferC pushed a commit that referenced this pull request Apr 11, 2020
@iolaszlo @KristofferC
Add hpmv! to BLAS in stdlib/LinearAlgebra (#34211)
0af280a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees
No one assigned
Labels
linear algebra Linear algebra needs news A NEWS entry is required for this change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iolaszlo @ViralBShah @dkarrasch @JeffBezanson @StefanKarpinski @ararslan