Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add promoting ops for Dates.Period #782

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

kleinschmidt
Copy link
Contributor

Fixes #781

I'm not sure how to figure out exactly which 1.8-DEV.XXX is the right version guard for this; the relevant changes were introduced in this commit: JuliaLang/julia@bdf9ead

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #782 (6693a6f) into master (dce2f96) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
+ Coverage   91.56%   91.63%   +0.06%     
==========================================
  Files           2        2              
  Lines         249      251       +2     
==========================================
+ Hits          228      230       +2     
  Misses         21       21              
Impacted Files Coverage Δ
src/Compat.jl 92.17% <100.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs an entry in the README.

Also, feel free to bump the version in Project.toml and we can tag a release immediately after merging.

@martinholters martinholters added the needs-news Needs an entry in the README label Sep 30, 2022
@kleinschmidt
Copy link
Contributor Author

bump @martinholters (or anyone!)

@martinholters martinholters merged commit ef073e1 into JuliaLang:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-news Needs an entry in the README
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add div(::Period, ::Period) method that's present in 1.8
2 participants