Add ismutabletype #759
Add ismutabletype #759
Conversation
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
==========================================
- Coverage 78.56% 78.45% -0.11%
==========================================
Files 4 4
Lines 639 636 -3
==========================================
- Hits 502 499 -3
Misses 137 137
Continue to review full report at Codecov.
|
src/Compat.jl
Outdated
| @@ -1195,6 +1195,16 @@ if VERSION < v"1.7.0-DEV.793" | |||
| end | |||
| end | |||
|
|
|||
| if !isdefined(Base, Symbol("ismutabletype")) | |||
There was a problem hiding this comment.
Using a VERSION check has the benefit of letting us know at what point in the future we can drop this. Though that is not a must, obviously.
There was a problem hiding this comment.
Remind me on how I best get the VERSION. Two steps, I think: find the commit (and its git sha1), then translate sha1 to "DEV.xyz".
There was a problem hiding this comment.
Correct. Step 1 involves the usual archaeology, e.g. searching through the Github PRs and identify the merge commit or use blame on the relevant code. Step 2 is then commit-name.sh [COMMIT_SHA].
|
Bump & xref JuliaIO/JLD.jl#302 |
mauro3
force-pushed
the
m3/ismutabletype
branch
from
514f7e9 to
a3c6310
Compare
|
All done. |
|
Thanks so much, @mauro3! |
Not sure this follows the rules.