Avoid extra buffer indirection during decoding #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 81.68% 81.50% -0.19%
==========================================
Files 6 6
Lines 202 200 -2
==========================================
- Hits 165 163 -2
Misses 37 37
☔ View full report in Codecov by Sentry. |
|
Thanks for fixing this! I knew there's room for improvement here but I failed to figure out how. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the profiler recorded a lot of time in the
copyto!code, so I tried refactoring that. To me it seems to be equivalent behavior, let's see what CI says. The memory gain is actually not much, but the time gained is about half.