Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix show_json to serialize empty NamedTuple #293

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Fix show_json to serialize empty NamedTuple #293

merged 1 commit into from
Dec 11, 2019

Conversation

0x005c
Copy link
Contributor

@0x005c 0x005c commented Oct 24, 2019 •
edited
Loading

As shown in #279, JSON.json(NamedTuple()) failed.
This is because lower(NamedTuple()) fails (because nfields(NamedTuple()) is 0).
So, I changed show_json(NamedTuple()) not to call lower().

fixes #279

quinnj
quinnj approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TotalVerb
Copy link
Collaborator

travis failure is #295, so I'm merging

@TotalVerb TotalVerb merged commit 8f53dc0 into JuliaIO:master Dec 11, 2019
@yiyuezhuo yiyuezhuo mentioned this pull request Sep 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't serialize empty NamedTuple
3 participants
@0x005c @TotalVerb @quinnj