Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ppi argument for PNG files #375

Merged
merged 2 commits into from
May 2, 2023
Merged

Add support for ppi argument for PNG files #375

merged 2 commits into from
May 2, 2023

Conversation

davidanthoff
Copy link
Contributor

With this one will be able to set a ppi configuration when saving Vega.jl or VegaLite.jl plots. For example:

@vlplot(:point, rand(10), rand(10)) |> save("foo.png", ppi=300)

will work.

@codecov
Copy link

codecov bot commented Apr 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.11 ⚠️

Comparison is base (a18ea04) 91.08% compared to head (6a9115c) 90.98%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
- Coverage   91.08%   90.98%   -0.11%     
==========================================
  Files          10       10              
  Lines         707      710       +3     
==========================================
+ Hits          644      646       +2     
- Misses         63       64       +1
Impacted Files Coverage Δ
src/mimesave.jl 75.86% <75.00%> (-1.92%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidanthoff
Copy link
Contributor Author

@SimonDanisch or @timholy any chance you could merge this? I have new things lined up on the Vega.jl/VegaLite.jl side of things that are ready to go as soon as this is merged and a new version is tagged. Thanks!

@davidanthoff
Copy link
Contributor Author

Bump, any chance this could be merged and a new version tagged?

I added another commit that fixed a CI failure, so I think this should all be good to go now.

CC @timholy, @SimonDanisch, @sjkelly, @johnnychen94 (I hope I pinged the right folks, I just looked who has merged things lately).

This was referenced May 2, 2023
Merged
Merged
@sjkelly sjkelly merged commit cc284cf into JuliaIO:master May 2, 2023
@davidanthoff davidanthoff deleted the ppi branch May 2, 2023 18:59
@davidanthoff
Copy link
Contributor Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidanthoff @sjkelly