Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM is moving to a model where all pointer types in IR are opaque (https://llvm.org/docs/OpaquePointers.html) this is currently enabled-by-default for LLVM 16 and will be required for LLVM 17.
This change moves cbe to support and use opaque pointers:
Value::getValueType
) use that helper instead ofgetType()->getNonOpaquePointerElementType()
.void*
for pointersFunctionInfoVariant
(which is a variant ofFunction
andCallInst
) instead ofFunctionType
for generating function declarations and prototypes, as this maintains information about struct return types, by-val param types, etc.TopoligicalSorter
: function declarations will not usevoid*
for function pointers, thus it doesn't matter the order that we emit them in.isStandardMain
can only check that thechar **
parameter corresponds to a pointer parameter, rather than an actualchar **
.printGEPExpression
andwriteMemoryAccess
will cast the pointer operand to the appropriate type.printGEPExpression
to remove "last index is vector" workaround.Fixes #154